pgsql: Change fix_scan_expr() to avoid copying the input node tree in

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Change fix_scan_expr() to avoid copying the input node tree in
Date: 2007-11-24 00:39:44
Message-ID: 20071124003944.E07B67540F0@cvs.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Change fix_scan_expr() to avoid copying the input node tree in the common case
where rtoffset == 0. In that case there is no need to change Var nodes,
and since filling in unset opfuncid fields is always safe, scribbling on the
input tree to that extent is not objectionable. This brings the cost of this
operation back down to what it was in 8.2 for simple queries. Per
investigation of performance gripe from Guillaume Smet.

Modified Files:
--------------
pgsql/src/backend/optimizer/plan:
setrefs.c (r1.139 -> r1.140)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/setrefs.c?r1=1.139&r2=1.140)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2007-11-24 01:32:48 pgsql: Borland CC 5.5.1 needs ssize_t, per cnliou9@fastmail.fm.
Previous Message Tom Lane 2007-11-23 19:57:45 pgsql: Avoid uselessly building a duplicate of the original clause in