Skip site navigation (1) Skip section navigation (2)

Re: Fix pg_dump dependency on postgres.h

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Fix pg_dump dependency on postgres.h
Date: 2007-11-21 22:45:56
Message-ID: 200711212245.lALMjuS21402@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Zdenek Kotala wrote:
> Bruce Momjian wrote:
> > Tom Lane wrote:
> >> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> >>> Huh, I think the point is to be able to build 8.3 at all on certain
> >>> Solaris releases.  I think it qualifies as a portability fix.
> >> (a) it wasn't "to build at all", it was to allow "inline" to be enabled
> >> on Sun Studio's compiler, which apparently is too dumb to not generate
> >> copies of an unreferenced inline function.
> >>
> >> (b) portability fix or not, this ain't going into 8.3.  It's *far* too
> >> invasive for this late stage of the cycle.
> > 
> > Yea, that was my analysis too.
> > 
> 
> Yes, I agree with Bruce and Tom. It is more invasive then I expected. 
> And specially in context when pg_resetxlog needs to be also fixed and 
> this fix seems more complicated then pg_dump fix :(.

The good news is that we will have it ready for 8.4.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Gregory WilliamsonDate: 2007-11-21 23:07:24
Subject: Re: 8.3devel slower than 8.2 under read-only load
Previous:From: Bruce MomjianDate: 2007-11-21 22:36:26
Subject: Re: [HACKERS] wrong behavior using to_char() again

pgsql-patches by date

Next:From: Bruce MomjianDate: 2007-11-21 23:13:02
Subject: Re: [BUGS] BUG #3770: Follow up: Fail to make bcc32.mak for libpq
Previous:From: Bruce MomjianDate: 2007-11-21 22:36:26
Subject: Re: [HACKERS] wrong behavior using to_char() again

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group