From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Oleg Bartunov <oleg(at)sai(dot)msu(dot)su>, Teodor Sigaev <teodor(at)sigaev(dot)ru>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Fix for stop words in thesaurus file |
Date: | 2007-11-09 16:39:03 |
Message-ID: | 200711091639.lA9Gd3I28633@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers pgsql-patches |
Simon Riggs wrote:
> > I have developed the attached patch which uses "?" to mark stop words in
> > the thesaurus file. ("*" was already in use in the file.) I updated
> > the docs to use "?", which makes the documentation clearer too.
> >
> > The patch also reenables testing of stop words in the thesuarus file.
> >
> > FYI, there is no longer a NOTICE for stop words in the thesaurus file;
> > it throws an error now, and says to use "?" instead.
>
> So this fix requires people to have a different dictionary file from 8.2
> to 8.3, and to manually edit the file? That makes upgrade even harder
> and more error prone.
>
> Seems easier to do it the way Tom suggested and only emit notices in the
> first case.
There is no easy way to do that so I have not heard that proposed as an
actual solution.
> I notice there's still a placeholder in the docs for how to upgrade.
> Perhaps if we wrote that now it would make it clearer where the
> difficulties lie?
Yes, this would be one of the many changes in the API. Of course, if
you did use a stop word you would now get an error and it would tell you
explicitly to use "?" for stop words, so I don't see a problem here.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://postgres.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Treat | 2007-11-09 16:46:05 | Re: [COMMITTERS] pgsql: - Add check of already changed page while replay WAL. |
Previous Message | Bruce Momjian | 2007-11-09 16:36:04 | pgsql: Move pl/proxy into Multi-server parallel query execution |
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Smet | 2007-11-09 16:39:51 | Re: [HACKERS] Estimation problem with a LIKE clause containing a / |
Previous Message | Tom Lane | 2007-11-09 16:33:45 | Re: [HACKERS] Estimation problem with a LIKE clause containing a / |
From | Date | Subject | |
---|---|---|---|
Next Message | Jan Urbański | 2007-11-09 16:47:31 | Re: a tsearch2 (8.2.4) dictionary that only filters out stopwords |
Previous Message | Magnus Hagander | 2007-11-09 13:24:16 | Re: krb_match_realm |