Skip site navigation (1) Skip section navigation (2)

pgsql: Fix xmlelement() to initialize libxml correctly before using it,

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix xmlelement() to initialize libxml correctly before using it,
Date: 2007-11-05 22:23:07
Message-ID: 20071105222307.B6448754229@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Fix xmlelement() to initialize libxml correctly before using it, and to avoid
assuming that evaluation of its input expressions won't change the state of
libxml.  This requires refactoring xml_init() to not call xmlInitParser(),
since now not all of its callers want that.  I also tweaked things to avoid
repeated execution of one-time-only tests inside xml_init(), though this is
mostly for clarity rather than in hopes of saving any noticeable amount of
runtime.  Per report from Sheikh Amjad and subsequent discussion.
In passing, fix a couple of inadequately schema-qualified queries.

Modified Files:
--------------
    pgsql/src/backend/utils/adt:
        xml.c (r1.49 -> r1.50)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/xml.c?r1=1.49&r2=1.50)

pgsql-committers by date

Next:From: Tom LaneDate: 2007-11-06 03:06:28
Subject: pgsql: Some code review for xml.c: Add some more xml_init() calls that
Previous:From: User FxjrDate: 2007-11-05 21:49:35
Subject: npgsql - Npgsql2: Added initial information about System.Transactions

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group