Skip site navigation (1) Skip section navigation (2)

Re: Re: [COMMITTERS] pgsql: Close previously open holes for invalidly encoded data to enter

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Close previously open holes for invalidly encoded data to enter
Date: 2007-11-01 23:23:14
Message-ID: 200711012323.lA1NNEq12594@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Andrew Dunstan wrote:
> 
> 
> Bruce Momjian wrote:
> > Andrew Dunstan wrote:
> >   
> >> Tom Lane wrote:
> >>     
> >>> OTOH we may be talking at cross-purposes --- on looking into gram.y
> >>> I see that this syntax is transformed to a call of convert_using(),
> >>> which may mean it has nothing to do with your changes.
> >>>
> >>> 	
> >>>   
> >>>       
> >> No, I changed convert_using - 
> >> http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/catalog/pg_conversion.c?r1=1.36&r2=1.37
> >>
> >> We can revert that if necessary. It will open up a hole, though. Take 
> >> your pick - spec compliance or validly coded data.
> >>     
> >
> > Is this a TODO?
> >   
> 
> No, we're long past this point. We've dropped 'convert ... using' entirely.

The question is whether re-adding it should be a TODO.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>        http://momjian.us
  EnterpriseDB                             http://postgres.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2007-11-01 23:26:41
Subject: Re: Re: [COMMITTERS] pgsql: Close previously open holes for invalidly encoded data to enter
Previous:From: Andrew DunstanDate: 2007-11-01 22:52:16
Subject: Re: Re: [COMMITTERS] pgsql: Close previously open holes for invalidly encoded data to enter

pgsql-committers by date

Next:From: Tom LaneDate: 2007-11-01 23:26:41
Subject: Re: Re: [COMMITTERS] pgsql: Close previously open holes for invalidly encoded data to enter
Previous:From: Andrew DunstanDate: 2007-11-01 22:52:16
Subject: Re: Re: [COMMITTERS] pgsql: Close previously open holes for invalidly encoded data to enter

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group