Skip site navigation (1) Skip section navigation (2)

pgsql: Fix an error in make_outerjoininfo introduced by my patch of

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix an error in make_outerjoininfo introduced by my patch of
Date: 2007-10-24 20:54:28
Message-ID: 20071024205428.06D4F754229@cvs.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Fix an error in make_outerjoininfo introduced by my patch of 30-Aug: the code
neglected to test whether an outer join's join-condition actually refers to
the lower outer join it is looking at.  (The comment correctly described what
was supposed to happen, but the code didn't do it...)  This often resulted in
adding an unnecessary constraint on the join order of the two outer joins,
which was bad enough.  However, it also seems to expose a performance
problem in an older patch (from 15-Feb): once we've decided that there is a
join ordering constraint, we will start trying clauseless joins between every
combination of rels within the constraint, which pointlessly eats up lots of
time and space if there are numerous rels below the outer join.  That probably
needs to be revisited :-(.  Per gripe from Jakub Ouhrabka.

Modified Files:
--------------
    pgsql/src/backend/optimizer/plan:
        initsplan.c (r1.134 -> r1.135)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/plan/initsplan.c?r1=1.134&r2=1.135)

pgsql-committers by date

Next:From: Tom LaneDate: 2007-10-24 20:54:33
Subject: pgsql: Fix an error in make_outerjoininfo introduced by my patch of
Previous:From: Alvaro HerreraDate: 2007-10-24 20:11:00
Subject: pgsql: Danish_Danmark -> Danish_Denmark

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group