Skip site navigation (1) Skip section navigation (2)

Re: BUG #3681: fillers are NULL in pgbench

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-bugs(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: BUG #3681: fillers are NULL in pgbench
Date: 2007-10-18 03:21:13
Message-ID: 20071018120752.8A98.ITAGAKI.TAKAHIRO@oss.ntt.co.jp (view raw or flat)
Thread:
Lists: pgsql-bugspgsql-patches
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> "ITAGAKI Takahiro" <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> > All of filler fields in branches, tellers and history is NULL. It is
> > probabbly a mistake because there are fields of char(22-88) in the table
> > definitions.
> > TPC-B requires at least 100 bytes per row for all tables used in it.
> 
> I'm not in favor of changing this.  pgbench has never pretended to be
> "really" TPC-B, nor has anyone ever tried to compare its numbers against
> other TPC-B numbers.  On the other hand, people *do* compare pgbench
> numbers to itself over time, and if we make a change like this it will
> break comparability of the results.

Ok, I feel it reasonable.
The attached is a patch to mention it in the source code.

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center


Attachment: pgbench-tpcb.patch
Description: application/octet-stream (2.3 KB)

In response to

Responses

pgsql-bugs by date

Next:From: Julius StroffekDate: 2007-10-18 13:20:05
Subject: Re: 'on insert do instead' rule with a where clause responds 'INSERT 0 0'
Previous:From: Douglas ToltzmanDate: 2007-10-18 01:17:55
Subject: Re: BUG #3680: memory leak when excuting a SQL "selectcount(id) from chinatelecom;"

pgsql-patches by date

Next:From: Jacky LengDate: 2007-10-18 06:04:15
Subject: Re: Why copy_relation_data only use wal when WALarchiving is enabled
Previous:From: Jacky LengDate: 2007-10-18 01:27:49
Subject: Re: Why copy_relation_data only use wal whenWALarchivingis enabled

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group