libpq crash fix [was: Provide a way to not ask for a password in psql]

From: Martin Pitt <martin(at)piware(dot)de>
To: pgsql-bugs(at)postgresql(dot)org
Subject: libpq crash fix [was: Provide a way to not ask for a password in psql]
Date: 2007-10-09 14:32:02
Message-ID: 20071009143202.GC7103@piware.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-patches

Hi again,

Martin Pitt [2007-10-09 15:56 +0200]:
> (2) PGPASSFILE=/dev/null psql -l
>
> With /dev/null I get a segfault (I'll probably send a patch for
> that later).

Ah, it tried to free(pgpassfile) in PasswordFromFile(), but that is a
local stack variable.

Can you please apply this upstream?

Thanks,

Martin

--
Martin Pitt http://www.piware.de
Ubuntu Developer http://www.ubuntu.com
Debian Developer http://www.debian.org

Attachment Content-Type Size
12-pgpassfile-crash.patch text/x-diff 537 bytes

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Magnus Hagander 2007-10-09 15:04:49 Re: libpq crash fix [was: Provide a way to not ask for a password in psql]
Previous Message Martin Pitt 2007-10-09 13:56:33 Provide a way to not ask for a password in psql

Browse pgsql-patches by date

  From Date Subject
Next Message Magnus Hagander 2007-10-09 15:04:49 Re: libpq crash fix [was: Provide a way to not ask for a password in psql]
Previous Message Martin Pitt 2007-10-09 13:56:33 Provide a way to not ask for a password in psql