Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL
Date: 2007-10-03 13:58:20
Message-ID: 20071003135820.GN22596@svr2.hagander.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Tue, Oct 02, 2007 at 10:04:19AM -0400, Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> >> I thought of a compromise. We can put back a check if the file exists without using bio. That would cover some 99 percent of the messages coming out of that 
> >> routine, I bet. And things would still work correct in 0.9.8.
> 
> > Here's an example of what I meant.
> 
> +1, but I think you should "#ifndef HAVE_ERR_SET_MARK" the added code.
> Also, maybe try to fopen rather than just fstat?

Done on both, and applied.

//Magnus

In response to

pgsql-hackers by date

Next:From: Alvaro HerreraDate: 2007-10-03 14:02:28
Subject: Re: First steps with 8.3 and autovacuum launcher
Previous:From: Michael MeskesDate: 2007-10-03 13:22:35
Subject: Re: ECPG regression tests

pgsql-committers by date

Next:From: Michael MeskesDate: 2007-10-03 14:01:28
Subject: pgsql: Stripped two symbols that are needed.
Previous:From: Magnus HaganderDate: 2007-10-03 13:57:52
Subject: pgsql: Attempt to open certificate file "manually" using fopen before

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group