Re: ecpg DllMain fix

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Michael Meskes <meskes(at)postgresql(dot)org>
Cc: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: ecpg DllMain fix
Date: 2007-10-03 09:13:27
Message-ID: 20071003091327.GD22051@svr2.hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Wed, Oct 03, 2007 at 10:58:18AM +0200, Michael Meskes wrote:
> On Wed, Oct 03, 2007 at 11:54:44AM +0900, ITAGAKI Takahiro wrote:
> > Here is a patch to remove DllMain from libecpg on Win32 build.
> > I brought the initialization routine from libpq and implemented
> > pthread_once() using a lock that serializes all pthread_once calls.
> > I don't have msvc build environment, but I hope it will fix the
> > build failure on it.
>
> We will see. Since it doesn't break my linux system I committed the
> patch. If anyone notices a problem please tell me.

Heh, I was about to review that. I'll try to get to it right after lunch.

//Magnus

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Heikki Linnakangas 2007-10-03 09:36:12 Doc update: ALTER SEQUENCE name RENAME TO can be rolled back
Previous Message Michael Meskes 2007-10-03 08:59:31 Re: ecpg thread-safe descriptor