Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: tgl(at)sss(dot)pgh(dot)pa(dot)us
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL
Date: 2007-10-02 09:18:23
Message-ID: 20071002091823.GF14143@svr2.hagander.net (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
On Tue, Oct 02, 2007 at 08:42:28AM +0200, Magnus Hagander wrote:
> > > http://www.openssl.org/docs/crypto/ERR_set_mark.html
> > > says
> > > ERR_set_mark() and ERR_pop_to_mark() were added in OpenSSL 0.9.8.
> > 
> > > Ooops.  Back to the drawing board.
> > 
> > To get the buildfarm going again, I applied a patch that turns these
> > calls into no-ops if the local OpenSSL hasn't got the functions.
> > I'm not entirely sure if the net result is a regression for pre-0.9.8
> > OpenSSLs or not --- Magnus, any thoughts on that?
> > 
> 
> I thought of a compromise. We can put back a check if the file exists without using bio. That would cover some 99 percent of the messages coming out of that 
> routine, I bet. And things would still work correct in 0.9.8.

Here's an example of what I meant.

I think this can be reasonable - OpenSSL 0.9.8 is from 2005 after all, so
it's not like we're requiring something extremely new..

//Magnus

In response to

Responses

pgsql-hackers by date

Next:From: Michael PaesoldDate: 2007-10-02 09:19:54
Subject: Re: First steps with 8.3 and autovacuum launcher
Previous:From: Brendan JurdDate: 2007-10-02 08:35:21
Subject: Re: [HACKERS] Function structure in formatting.c

pgsql-committers by date

Next:From: Tatsuo IshiiDate: 2007-10-02 09:40:19
Subject: Re: pgsql: Fix free space map to correctly track the total amount of FSM
Previous:From: Magnus HaganderDate: 2007-10-02 06:42:28
Subject: Re: [COMMITTERS] pgsql: Use BIO functions to avoid passing FILE * pointers to OpenSSL

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group