Skip site navigation (1) Skip section navigation (2)

Re: OpenSSL Applink

From: "Dave Page" <dpage(at)postgresql(dot)org>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Magnus Hagander" <magnus(at)hagander(dot)net>, "Andrew Dunstan" <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: OpenSSL Applink
Date: 2007-09-29 07:43:36
Message-ID: 200709290843370000@02967250 (view raw or flat)
Thread:
Lists: pgsql-patches

> ------- Original Message -------
> From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> To: Dave Page <dpage(at)postgresql(dot)org>
> Sent: 29/09/07, 01:28:09
> Subject: Re: [PATCHES] OpenSSL Applink
> 
> I concur with Magnus that it'll be better if there's not two code paths
> here.  It's not entirely clear whether BIO_new_fp() would avoid the
> problematic calls, but it doesn't look like it'd be hard to try.

The last version of the patch I posted uses BIO_new_file() in all cases, and (from memory) BIO_get_fp() in the non-win32 case to get a FILE* to pass to fstat.

I believe the problem is sharing FILE*'s between differing runtime versions used by openssl and the app. Coding it with BIO_new_file makes it less tempting for future changes to start mucking about with FILE*'s on Windows.

Note that I've been away from my *nix boxes so I haven't tested the patch except on Windows yet.

/D

Responses

pgsql-patches by date

Next:From: Simon RiggsDate: 2007-09-29 07:59:21
Subject: set_ps_display during recovery
Previous:From: Magnus HaganderDate: 2007-09-29 07:16:05
Subject: Re: Add chklocale.c to msvc build

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group