Skip site navigation (1) Skip section navigation (2)

Re: Other ecpg thread unsafety

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Other ecpg thread unsafety
Date: 2007-09-26 10:08:12
Message-ID: 20070926100812.GA8921@feivel.credativ.de (view raw or flat)
Thread:
Lists: pgsql-hackers
On Wed, Sep 26, 2007 at 05:56:59PM +0900, ITAGAKI Takahiro wrote:
>   [1] all_descriptors in ecpg/ecpglib/descriptor.c:
>       Management of descriptors used by SQL DESCRIPTOR is not safe.
> 
>   [2] auto_allocs in ecpg/ecpglib/memory.c:
>       All memory allocation for statements are not safe.

These two should suffer from the same problem prep_stmt suffered from.

>   [3] nextStmtID in ecpg/ecpglib/prepare.c:
>       Increment is not safe in ECPGauto_prepare().

Not sure whether this is really a problem, but if we're fixing stuff
anyway, why not play it safe.

>   [4] stmtCacheEntries in ecpg/ecpglib/prepare.c:
>       Reading/writing are not safe in ECPGauto_prepare().

This also doesn't look like a dangerous bug, but it's still not working
as it should. I'd say let's fix them all.

Michael
-- 
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2007-09-26 10:42:19
Subject: Re: stored procedure stats in collector
Previous:From: Bruce MomjianDate: 2007-09-26 09:53:07
Subject: 8.3 performance features presentation

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group