Various fixes for syslogger

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: pgsql-patches(at)postgresql(dot)org
Subject: Various fixes for syslogger
Date: 2007-09-20 05:06:25
Message-ID: 20070920130516.67D9.ITAGAKI.TAKAHIRO@oss.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Here are various fixes for syslogger.

- syslogger_parseArgs_assert.patch (bug #3621)
The assertion in syslogger_parseArgs() was wrong. The number of
arguments passed to syslogger is changed to 4 in 8.1 or later.
This patch should be appled to 8.1, 8.2 and 8.3dev.

- logfile_rotate.patch (bug #3622)
This patch fixes two bugs in the log file rotation.
This is only for 8.3dev.
1. pg_rotate_logfile() force log files to rotate. Both .log and .csv
files are treated the same way as size-limited rotation.
2. Fix a copy-and-paste bug in updating csvlogFile. CSV log was lost
after swiching files in all case of the rotations.

- remove_redirect_stderr.patch
redirect_stderr is renamed to logging_collector, but the old name
is left in postgresql.conf. This is only for 8.3dev.

BTW, I found empty .log files are created under $PGDATA/pg_log/ even if
log_destination does not contain 'stderr' (i.e, only csvlog or syslog).
Is this an intentional behavior?

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center

Attachment Content-Type Size
syslogger_parseArgs_assert.patch application/octet-stream 318 bytes
logfile_rotate.patch application/octet-stream 805 bytes
remove_redirect_stderr.patch application/octet-stream 426 bytes

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message sayali k 2007-09-20 05:49:37 Implementation of aggregate functions
Previous Message Andrew Dunstan 2007-09-20 00:14:56 Re: like/ilike improvements