Skip site navigation (1) Skip section navigation (2)

XLogCacheByte is unused

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: pgsql-patches(at)postgresql(dot)org
Subject: XLogCacheByte is unused
Date: 2007-08-27 10:30:30
Message-ID: 20070827192456.74A2.ITAGAKI.TAKAHIRO@oss.ntt.co.jp (view raw or flat)
Thread:
Lists: pgsql-patches
I found XLogCtlData.XLogCacheByte is already unused in CVS HEAD.
Should we remove the variable, or reserve it for future use?

Index: src/backend/access/transam/xlog.c
===================================================================
--- src/backend/access/transam/xlog.c	(revision 1268)
+++ src/backend/access/transam/xlog.c	(working copy)
@@ -317,7 +317,6 @@
 	 */
 	char	   *pages;			/* buffers for unwritten XLOG pages */
 	XLogRecPtr *xlblocks;		/* 1st byte ptr-s + XLOG_BLCKSZ */
-	Size		XLogCacheByte;	/* # bytes in xlog buffers */
 	int			XLogCacheBlck;	/* highest allocated xlog buffer index */
 	TimeLineID	ThisTimeLineID;
 
@@ -4115,8 +4114,6 @@
 	 * Do basic initialization of XLogCtl shared data. (StartupXLOG will fill
 	 * in additional info.)
 	 */
-	XLogCtl->XLogCacheByte = (Size) XLOG_BLCKSZ *XLOGbuffers;
-
 	XLogCtl->XLogCacheBlck = XLOGbuffers - 1;
 	XLogCtl->Insert.currpage = (XLogPageHeader) (XLogCtl->pages);
 	SpinLockInit(&XLogCtl->info_lck);

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center


Responses

pgsql-patches by date

Next:From: Dawid KuroczkoDate: 2007-08-27 13:24:26
Subject: Re: LDAP service lookup
Previous:From: Albe LaurenzDate: 2007-08-27 07:29:21
Subject: Re: LDAP service lookup

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group