Skip site navigation (1) Skip section navigation (2)

Re: reindexdb hangs

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: dx k9 <bitsandbytes88(at)hotmail(dot)com>, pgsql-admin(at)postgresql(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: reindexdb hangs
Date: 2007-08-25 22:21:50
Message-ID: 20070825222150.GU31461@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-adminpgsql-hackers
Tom Lane wrote:
> "dx k9" <bitsandbytes88(at)hotmail(dot)com> writes:
> > [ stuck reindex ]
> > It turns out it was a temporary database and temporary table, that just 
> > wasn't there maybe it thought it was there from some type of snapshot then 
> > the next minute it was gone.
> 
> Hmm, there is not any filter in ReindexDatabase() to exclude temp tables
> of other backends, but it sure seems like there needs to be.  CLUSTER
> might have the same issue.  I think we fixed this in VACUUM long ago,
> but we need to check the other commands that grovel over all of a database.

Was this ever fixed?  I think it wasn't, because I don't see any check
in ReindexDatabase.  Here is a patch to add one.

I examined cluster.c and it does seem to be missing a check too.  I'm
not sure where to add one though; the best choice would be the place
where the list of rels is built, but that scans only pg_index, so it
doesn't have access to the namespace of each rel.  So one idea would be
to get the pg_class row for each candidate, but that seems slow.
Another idea would be to just add all the candidates and silently skip
the temp indexes in cluster_rel.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

Attachment: reindex-temp.patch
Description: text/x-diff (790 bytes)

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2007-08-25 22:39:29
Subject: Re: [WIP PATCH] Lazily assign xids for toplevel Transactions
Previous:From: Florian G. PflugDate: 2007-08-25 21:45:08
Subject: [WIP PATCH] Lazily assign xids for toplevel Transactions

pgsql-admin by date

Next:From: Tom LaneDate: 2007-08-25 22:51:53
Subject: Re: reindexdb hangs
Previous:From: Kenji MorishigeDate: 2007-08-24 22:05:22
Subject: Re: Warm-Backup configuration question

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group