Skip site navigation (1) Skip section navigation (2)

Reduce the size of PageFreeSpaceInfo on 64bit platform

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
To: pgsql-patches(at)postgresql(dot)org
Subject: Reduce the size of PageFreeSpaceInfo on 64bit platform
Date: 2007-08-10 01:32:35
Message-ID: 20070810095003.754D.ITAGAKI.TAKAHIRO@oss.ntt.co.jp (view raw or flat)
Thread:
Lists: pgsql-patches
Here is a patch to reduce the size of PageFreeSpaceInfo on 64bit platform.
We will utilize maintenance_work_mem twice with the patch.

The sizeof(PageFreeSpaceInfo) is 16 bytes there because the type of 'avail'
is 'Size', that is typically 8 bytes and needs to be aligned in 8-byte bounds.
I changed the type of the field to uint32. We can store the freespace with
uint16 at smallest, but the alignment issue throws it away.

If we need to store freespace more compactly rather than calculation speed,
it might be good to use FSMPageData instead of PageFreeSpaceInfo, but I did
not change it in this patch.


Index: src/include/storage/freespace.h
===================================================================
--- src/include/storage/freespace.h	(head)
+++ src/include/storage/freespace.h	(fixed)
@@ -24,7 +24,7 @@
 typedef struct PageFreeSpaceInfo
 {
 	BlockNumber blkno;			/* which page in relation */
-	Size		avail;			/* space available on this page */
+	uint32		avail;			/* space available on this page */
 } PageFreeSpaceInfo;
 
 
----

Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center


Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2007-08-10 04:45:32
Subject: Re: Reduce the size of PageFreeSpaceInfo on 64bit platform
Previous:From: Brendan JurdDate: 2007-08-09 12:09:19
Subject: Re: Function structure in formatting.c

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group