Skip site navigation (1) Skip section navigation (2)

Re: tsearch core path, v0.58

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Teodor Sigaev <teodor(at)sigaev(dot)ru>
Cc: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: tsearch core path, v0.58
Date: 2007-07-31 00:30:34
Message-ID: 200707310030.l6V0UYU04243@momjian.us (view raw or flat)
Thread:
Lists: pgsql-patches
I did my first minimal review of this patch.  First, it is massive ----
26k line diff for the new commands and functionality, and 31k for
adding snowball stemmer.  I am glad Oleg and Teodor wrote this because
they have been around this code for a while and are available to fix any
problems we find.

The patch looks well structured.  The majority is just standard glue to
add new commands, like CREATE/DROP, grammar, system catalogs, pg_dump,
cache entries, regression tests, etc.

---------------------------------------------------------------------------

Teodor Sigaev wrote:
> http://www.sigaev.ru/misc/tsearch_core-0.58.gz
> 
> Changes since 0.52 version:
> 
> 1) Introduce dictionary's template which contains only methods of dictionary and 
> can be managed only by superuser.
> CREATE TEXT SEARCH DICTIONARY dictname
>      TEMPLATE  dicttmplname
>      [OPTION  opt_text ]
> ;
> 
> CREATE TEXT SEARCH DICTIONARY TEMPLATE dicttmplname
>      LEXIZE  lexize_function
>      [INIT  init_function ]
> ;
> 
> DROP  TEXT SEARCH DICTIONARY TEMPLATE [IF EXISTS] dicttmplname  [CASCADE]
> ALTER TEXT SEARCH DICTIONARY TEMPLATE dicttmplname RENAME TO newname;
> 
> psql has \dFt command operated templates
> 
> 2) parser and dictionary template could be managed only by superuser (due to 
> security reasons pointed by Tom). So, they don't have owner columns and removed
> ALTER .. PARSER .. OWNER TO command
> 
> 4) As Bruce suggests, GUC variable tsearch_conf_name is renamed to 
> default_text_search_config and trigger tsearch is renamed to tsvector_update_trigger
> 
> 5) remove cfglocale and cfgdefault columns in configuration. So, CREATE/ALTER .. 
> CONFIGURATION hasn't AS DEFAULT and LOCALE options. Instead of that initdb tries 
> to find suitable configuration name for selected locale. Or it uses -T, 
> --text-search-config=CFG switch.
> 
> 6) pg_dump, psql are changed accordingly.
> 
> 
> -- 
> Teodor Sigaev                                   E-mail: teodor(at)sigaev(dot)ru
>                                                     WWW: http://www.sigaev.ru/
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 1: if posting/reading through Usenet, please send an appropriate
>        subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
>        message can get through to the mailing list cleanly

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2007-07-31 01:33:34
Subject: Re: tsearch core path, v0.58
Previous:From: Marko KreenDate: 2007-07-30 19:26:51
Subject: Re: pgcrypto

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group