Skip site navigation (1) Skip section navigation (2)

Re: plperl warnings on win32

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: plperl warnings on win32
Date: 2007-07-24 13:59:15
Message-ID: 20070724135915.GG19199@svr2.hagander.net (view raw or flat)
Thread:
Lists: pgsql-patches
On Tue, Jul 24, 2007 at 09:55:57AM -0400, Tom Lane wrote:
> Magnus Hagander <magnus(at)hagander(dot)net> writes:
> >   override CPPFLAGS += -DPLPERL_HAVE_UID_GID
> > + # Perl on win32 contains /* within comment all over the header file,
> > + # so disable this warning.
> > + override CFLAGS += -Wno-comment
> >   endif
> 
> If you insist you can apply that in some way that makes it Windows-only.
> I object strongly to the patch in this form, because it will mask our
> own mistakes as well as one particular Perl build's mistakes.

Uh, it's already inside a win32-only block. So it'll only affect mingw.

Do you know of a way to do it from inside gcc, like the #pragma that exists
for win32 to disable specific warnings? If so we could just disable it on
the line before we #include the perl header, and re-enable it after...

//Magnus

In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2007-07-24 14:01:07
Subject: Re: Async Commit, v21 (now: v22)
Previous:From: Gregory StarkDate: 2007-07-24 13:57:37
Subject: Re: msvc const warnings

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group