Skip site navigation (1) Skip section navigation (2)

Re: Synchronous Commit Doc Patch

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Synchronous Commit Doc Patch
Date: 2007-07-17 05:09:25
Message-ID: 200707170509.l6H59Pu11098@momjian.us (view raw or flat)
Thread:
Lists: pgsql-patches
Your patch has been added to the PostgreSQL unapplied patches list at:

	http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------


Simon Riggs wrote:
> On Fri, 2007-07-13 at 15:01 +0200, Reviewer wrote:
> 
> > I just read your patch in order to understand a little bit what will 
> > happen in the next release.
> 
> Thanks for the review. v2 attached.
> 
> > About the guc variable wal_writer_delay, you say at the end:
> > "This parameter can only
> > +         be set in the postgresql.conf file or on the server command line."
> > 
> > Well, I don't really understand if this parameter is set only at server 
> > startup or if it is possible to modify the postgresql.conf file and then 
> > reload the conf-files.
> 
> A common confusion. I'm not personally in favour of using that phrase in
> the docs, though it is the standard description of when to set this type
> of parameter, so I have followed the convention.
> 
> > Also, in the part about synchronous commit and fsync=off, there's just a 
> > missing verb, I think you should insist between the two possibilities : 
> > system or database server crash, maybe by using some bold.
> 
> I've reworded that part. Thanks for spotting this.
> 
> >  From a user point of view, I think the documentation is clear enough, 
> > but I admit beeing a bit lost in the real end of the explanation, the 
> > part about the transaction status hint bits but I think it's not that 
> > important. I think I understood synchronous and asynchronous commits.
> 
> I've added to and reworked that a bit also.
> 
> -- 
>   Simon Riggs
>   EnterpriseDB  http://www.enterprisedb.com

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 2: Don't 'kill -9' the postmaster

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-patches by date

Next:From: Bruce MomjianDate: 2007-07-17 05:22:56
Subject: Re: WIP: rewrite numeric division
Previous:From: Bruce MomjianDate: 2007-07-17 05:09:19
Subject: Re: Synchronous Commit Doc Patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group