| From: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: pgstat_drop_relation bugfix |
| Date: | 2007-07-13 08:08:24 |
| Message-ID: | 20070713170023.8E14.ITAGAKI.TAKAHIRO@oss.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > What I'm inclined to propose is that we just remove the
> > pgstat_drop_relation() call from smgr_internal_unlink
> On checking the CVS history, that in fact is how the code worked before
> 8.1.3, when I introduced the bogus call in a fit of over-optimization :-(.
I'm worried that we leave garbage entries in the stats. As you suggested,
don't we need to remove unreferenced entries from stats periodically?
> > and rely entirely
> > on VACUUM to clean out dead entries in the pgstats data.
Regards,
---
ITAGAKI Takahiro
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Huxton | 2007-07-13 08:35:55 | Re: Regarding Distributed Database features |
| Previous Message | Stefan Kaltenbrunner | 2007-07-13 07:17:46 | Re: compiler warnings on the buildfarm |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2007-07-13 08:29:59 | Re: BUG #3439: pg_standby and path name with space |
| Previous Message | ISHIDA Akio | 2007-07-12 19:36:54 | BUG #3439: pg_standby and path name with space |