Skip site navigation (1) Skip section navigation (2)

Re: Cancel autovacuum conflicting with DROP TABLE

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Cancel autovacuum conflicting with DROP TABLE
Date: 2007-06-29 17:19:29
Message-ID: 20070629171929.GF10563@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-patches
ITAGAKI Takahiro wrote:
> 
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> wrote:
> 
> > 1. changing SIGINT so that it cancels the current table instead of
> > shutting down the entire worker.

I applied this part of the patch, thanks.

In passing I noticed that apparently we are leaking memory, because the
vacuum memory context is created with a parent of PortalContext, which
ISTM to be NULL in autovacuum.  So when we cancel the vacuuming work, we
never delete or reset that context.

I think what we should be doing is creating a context to act as
PortalContext, and reset it after each vacuuming operation.

-- 
Alvaro Herrera                  http://www.amazon.com/gp/registry/5ZYLFMCVHXC
"El que vive para el futuro es un iluso, y el que vive para el pasado,
un imb├ęcil" (Luis Adler, "Los tripulantes de la noche")

In response to

pgsql-patches by date

Next:From: David FetterDate: 2007-06-29 18:32:19
Subject: Re: rename of a view
Previous:From: Tom LaneDate: 2007-06-29 16:35:44
Subject: Re: configure.in / xml / quoting trouble

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group