| From: | Alvaro Herrera <alvherre(at)commandprompt(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SetBufferCommitInfoNeedsSave and race conditions |
| Date: | 2007-06-28 19:29:48 |
| Message-ID: | 20070628192948.GA22200@alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane escribió:
> Heikki Linnakangas <heikki(at)enterprisedb(dot)com> writes:
> > AFAICS, we can just simply remove the assertion. But is there any
> > codepaths that assume that after calling HeapTupleSatisfiesSnapshot, all
> > appropriate hint bits are set?
>
> There had better not be, since we are going to postpone setting hint
> bits for recently-committed transactions as part of the async-commit
> patch.
>
> A quick grep suggests that VACUUM FULL might be at risk here.
That particular case seems easily fixed since VACUUM FULL must hold an
exclusive lock; and we can forcibly set sync commit for VACUUM FULL.
--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-06-28 19:47:43 | Re: SetBufferCommitInfoNeedsSave and race conditions |
| Previous Message | Tom Lane | 2007-06-28 19:16:15 | Re: SetBufferCommitInfoNeedsSave and race conditions |