Skip site navigation (1) Skip section navigation (2)

Re: SetBufferCommitInfoNeedsSave and race conditions

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Pavan Deolasee <pavan(dot)deolasee(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: SetBufferCommitInfoNeedsSave and race conditions
Date: 2007-06-28 19:29:48
Message-ID: 20070628192948.GA22200@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackers
Tom Lane escribió:
> Heikki Linnakangas <heikki(at)enterprisedb(dot)com> writes:
> > AFAICS, we can just simply remove the assertion. But is there any 
> > codepaths that assume that after calling HeapTupleSatisfiesSnapshot, all 
> > appropriate hint bits are set?
> 
> There had better not be, since we are going to postpone setting hint
> bits for recently-committed transactions as part of the async-commit
> patch.
> 
> A quick grep suggests that VACUUM FULL might be at risk here.

That particular case seems easily fixed since VACUUM FULL must hold an
exclusive lock; and we can forcibly set sync commit for VACUUM FULL.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2007-06-28 19:47:43
Subject: Re: SetBufferCommitInfoNeedsSave and race conditions
Previous:From: Tom LaneDate: 2007-06-28 19:16:15
Subject: Re: SetBufferCommitInfoNeedsSave and race conditions

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group