Re: Frustrating issue with PGXS

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Fabien COELHO <fabien(dot)coelho(at)ensmp(dot)fr>, Magnus Hagander <magnus(at)hagander(dot)net>, Eddie Stanley <eddiewould(at)paradise(dot)net(dot)nz>, mux(at)elvis(dot)mu(dot)org
Subject: Re: Frustrating issue with PGXS
Date: 2007-06-27 08:30:49
Message-ID: 200706271030.49754.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Am Dienstag, 26. Juni 2007 16:12 schrieb Tom Lane:
> True.  OK, then let's add the ifndef to Makefile.global and change the
> existing extension makefiles to
>
>         PG_CONFIG := pg_config
>         PGXS := $(shell $(PG_CONFIG) --pgxs)
>         include $(PGXS)
>
> Any objections?

Yes. I think that solution is wrong. It merely creates other possibilities
to use mismatching combinations. What was the problem with just making all
uses of pg_config in Makefile.global use a hardcoded bindir directly?

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Teodor Sigaev 2007-06-27 08:39:57 Re: tsearch in core patch
Previous Message Pavan Deolasee 2007-06-27 08:06:54 Re: HOT: Incomplete issues