Skip site navigation (1) Skip section navigation (2)

pgsql: Revert an ill-considered portion of my patch of 12-Mar, which

From: tgl(at)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Revert an ill-considered portion of my patch of 12-Mar, which
Date: 2007-06-17 18:57:29
Message-ID: 20070617185729.5AC299FB2ED@postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Revert an ill-considered portion of my patch of 12-Mar, which tried to save a
few lines in sql_exec_error_callback() by using the function source string
field that the patch added to SQL function cache entries.  This doesn't work
because the fn_extra field isn't filled in yet during init_sql_fcache().
Probably it could be made to work, but it doesn't seem appropriate to contort
the main code paths to make an error-reporting path a tad faster.  Per report
from Pavel Stehule.

Modified Files:
--------------
    pgsql/src/backend/executor:
        functions.c (r1.117 -> r1.118)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/functions.c.diff?r1=1.117&r2=1.118)

pgsql-committers by date

Next:From: Tom LaneDate: 2007-06-17 23:39:28
Subject: pgsql: Marginal hacking to improve the speed of COPY OUT.
Previous:From: Tom LaneDate: 2007-06-15 20:56:52
Subject: pgsql: Tweak the API for per-datatype typmodin functions so that they

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group