Skip site navigation (1) Skip section navigation (2)

Re: CREATE TABLE LIKE INCLUDING INDEXES support

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: NikhilS <nikkhils(at)gmail(dot)com>, Neil Conway <neilc(at)samurai(dot)com>, Trevor Hardcastle <chizu(at)spicious(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: CREATE TABLE LIKE INCLUDING INDEXES support
Date: 2007-05-22 15:48:38
Message-ID: 20070522154838.GC11032@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bruce Momjian escribió:
> 
> Your patch has been added to the PostgreSQL unapplied patches list at:
> 
> 	http://momjian.postgresql.org/cgi-bin/pgpatches
> 
> It will be applied as soon as one of the PostgreSQL committers reviews
> and approves it.

I noticed that this patch uses names for some things (for example it
gets the name of the access method), and then builds a IndexStmt which
contains the name.  I don't think this is a good idea.  I think what
should happen here is that the function to build indexes should be split
in two: one to resolve the names and fill a structure with Oids of
things, and another to get that structure and actually build the index
or constraint.  For example look into how GrantStmt is turned into
InternalGrant, and the stuff in aclchk.c to work with that.

-- 
Alvaro Herrera                                http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2007-05-22 15:53:06
Subject: Re: Inconsistant SQL results - Suspected error with query planing or query optimisation.
Previous:From: Bruce MomjianDate: 2007-05-22 15:38:43
Subject: Re: Concurrent psql patch

pgsql-patches by date

Next:From: Andrew DunstanDate: 2007-05-22 15:58:33
Subject: like/ilike improvements
Previous:From: Bruce MomjianDate: 2007-05-22 15:39:13
Subject: Re: Preliminary GSSAPI Patches

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group