Skip site navigation (1) Skip section navigation (2)

Re: Fix for large file support (nonsegment mode support)

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: pgsql-patches(at)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Fix for large file support (nonsegment mode support)
Date: 2007-04-30 22:31:57
Message-ID: 200704302231.l3UMVvt15147@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
This has been saved for the 8.4 release:

	http://momjian.postgresql.org/cgi-bin/pgpatches_hold

---------------------------------------------------------------------------

 Zdenek Kotala wrote:
> Tom Lane wrote:
> > [ redirecting to -hackers for wider comment ]
> > 
> > Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
> >> Tom Lane wrote:
> >> LET_OS_MANAGE_FILESIZE is good way. I think one problem of this option I 
> >> fixed. It is size of offset. I went thru the code and did not see any 
> >> other problem there. However, how you mentioned it need more testing. I 
> >> going to take server with large disk array and I will test it.
> > 
> >> I would like to add --enable-largefile switch to configure file to 
> >> enable access to wide group of users. What you think about it?
> > 
> > Yeah, I was going to suggest the same thing --- but not with that switch
> > name.  We already use enable/disable-largefile to control whether 64-bit
> > file access is built at all (this mostly affects pg_dump at the moment).
> > 
> > I think the clearest way might be to flip the sense of the variable.
> > I never found "LET_OS_MANAGE_FILESIZE" to be a good name anyway.  I'd
> > suggest "USE_SEGMENTED_FILES", which defaults to "on", and you can
> > turn it off via --disable-segmented-files if configure confirms your
> > OS has largefile support (thus you could not specify both this and
> > --disable-largefile).
> > 
> 
> There is latest version of nonsegment support patch. I changed 
> LET_OS_MANAGE_FILESIZE to USE_SEGMENTED_FILES and I added 
> -disable-segmented-files switch to configure. I kept tuplestore behavior 
> and it still split file in both mode.
> 
> I also little bit cleanup some other datatypes (e.g int->mode_t).
> Autoconf and autoheader must be run after patch application.
> 
> I tested it with 9GB table and both mode works fine.
> 
> Please, let me know your comments.
> 
> 		Zdenek

[ application/x-gzip is not supported, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 3: Have you checked our extensive FAQ?
> 
>                http://www.postgresql.org/docs/faq

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2007-04-30 22:33:18
Subject: Re: Heap page diagnostic functions
Previous:From: Bruce MomjianDate: 2007-04-30 22:25:04
Subject: Re: Feature freeze progress report

pgsql-patches by date

Next:From: Pavel StehuleDate: 2007-05-01 10:42:20
Subject: Re: plpgpsm
Previous:From: Zdenek KotalaDate: 2007-04-30 14:11:43
Subject: Re: Fix for large file support (nonsegment mode support)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group