Skip site navigation (1) Skip section navigation (2)

Re: New version of GENERATED/IDENTITY, was Re: parser dilemma

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Zoltan Boszormenyi <zb(at)cybertec(dot)at>
Cc: List pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: New version of GENERATED/IDENTITY, was Re: parser dilemma
Date: 2007-04-27 14:30:49
Message-ID: 200704271430.l3REUns25138@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Zoltan Boszormenyi wrote:
> Thanks.
> 
> But actually it didn't showed up at that page.
> For that matter, neither patch showed up on either pgpatches
> or pgpatches_hold that you indicated yesterday.

My apologies.  Something was misconfigured on my end.  The web pages are
fixed now.

---------------------------------------------------------------------------


> 
> Best regards,
> Zolt?n B?sz?rm?nyi
> 
> Bruce Momjian ?rta:
> > Your patch has been added to the PostgreSQL unapplied patches list at:
> >
> > 	http://momjian.postgresql.org/cgi-bin/pgpatches
> >
> > It will be applied as soon as one of the PostgreSQL committers reviews
> > and approves it.
> >
> > ---------------------------------------------------------------------------
> >
> >
> > Zoltan Boszormenyi wrote:
> >   
> >> Hi,
> >>
> >> some last changes. Really. :-)
> >>
> >> I made ALTER TABLE symmetric with CREATE TABLE
> >> so the grammar now has:
> >>
> >> ALTER TABLE tabname ALTER colname SET GENERATED
> >>    { ALWAYS | BY DEFAULT} AS IDENTITY [ ( sequence options )]
> >>
> >> This works intuitively the same as in CREATE TABLE, i.e.
> >> - it creates an OWNED sequence (if the column doesn't already have one)
> >> - it creates or alters the sequence with the given options
> >> - adds the DEFAULT expression with the proper generation behaviour
> >> in one go. I extended the documentation and modified the test case 
> >> accordingly.
> >> I also tested that an IDENTITY column can't be created with a type that
> >> cannot be cast from bigint i.e. box. I added it to the test case.
> >>
> >> Please, review.
> >>
> >> Best regards,
> >> Zolt?n B?sz?rm?nyi
> >>
> >> Zoltan Boszormenyi ?rta:
> >>     
> >>> And here it is attached. Sorry.
> >>>
> >>> Zoltan Boszormenyi ?rta:
> >>>       
> >>>> Hi,
> >>>>
> >>>> here's the patch with the modifications suggested by Tom Lane.
> >>>> The postfix rule was deleted from b_expr and the reverse parsing
> >>>> in ruleutils.c::get_oper_expr() always puts parentheses around
> >>>> postfix operators.
> >>>>
> >>>> Other changes:
> >>>> - OVERRIDING SYSTEM VALUE in COPY can appear
> >>>>   at any place in the option list.
> >>>> - pg_dump was modified accordingly
> >>>> - \copy built-in in psql now also accepts OVERRIDING SYSTEM VALUE
> >>>> - documentation and testcase updates
> >>>>
> >>>> Please, review.
> >>>>
> >>>> Best regards,
> >>>> Zolt?n B?sz?rm?nyi
> >>>>
> >>>>         
> >>> ------------------------------------------------------------------------
> >>>
> >>>
> >>> ---------------------------(end of broadcast)---------------------------
> >>> TIP 2: Don't 'kill -9' the postmaster
> >>>   
> >>>       
> >> -- 
> >> ----------------------------------
> >> Zolt?n B?sz?rm?nyi
> >> Cybertec Geschwinde & Sch?nig GmbH
> >> http://www.postgresql.at/
> >>
> >>     
> >
> > [ application/x-tar is not supported, skipping... ]
> >
> >   
> 
> 
> -- 
> ----------------------------------
> Zolt?n B?sz?rm?nyi
> Cybertec Geschwinde & Sch?nig GmbH
> http://www.postgresql.at/
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 9: In versions below 8.0, the planner will ignore your desire to
>        choose an index scan if your joining column's datatypes do not
>        match

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2007-04-27 14:33:23
Subject: Re: Interaction of PITR backups andBulkoperationsavoiding WAL
Previous:From: Tom LaneDate: 2007-04-27 14:28:26
Subject: Re: Windows support - PostgreSQL 8.0 and 8.1

pgsql-patches by date

Next:From: Jim NasbyDate: 2007-04-27 17:33:06
Subject: Re: too much WAL volume
Previous:From: Tom LaneDate: 2007-04-27 14:02:25
Subject: Re: Hash function for numeric (WIP)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group