Skip site navigation (1) Skip section navigation (2)

Re: ECPG failure on BF member Vaquita (Windows Vista)

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>,Andrew Dunstan <andrew(at)dunslane(dot)net>, Mark Wong <markwkm(at)gmail(dot)com>,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ECPG failure on BF member Vaquita (Windows Vista)
Date: 2007-04-27 06:53:09
Message-ID: 20070427065309.GA4375@feivel.credativ.de (view raw or flat)
Thread:
Lists: pgsql-hackers
On Thu, Apr 26, 2007 at 01:35:42PM -0400, Tom Lane wrote:
> AFAICS you do not need to inline create_statement.  The risk factor
> is where you call a routine that does something with a va_list, and
> then you want to do something else (other than va_end) with that va_list
> after it returns.  The one use of create_statement doesn't do that,
> hence no problem.  (We know this works, because stringinfo.c does it.)

Given all the problems I had so far with this code I'd prefer to keep it
inlined. :-)

> BTW, I think there is a small bug there: you fail to call va_end() in the
> failure path.  I'm not sure if there are any modern machines where
> va_end() isn't a no-op, but nonetheless the code isn't meeting the spec.

Fixed. Thanks.

Michael

-- 
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!

In response to

pgsql-hackers by date

Next:From: Michael MeskesDate: 2007-04-27 06:58:54
Subject: Re: ECPG failure on BF member Vaquita (Windows Vista)
Previous:From: Zoltan BoszormenyiDate: 2007-04-27 06:08:14
Subject: Re: New version of GENERATED/IDENTITY, was Re: parser dilemma

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group