Skip site navigation (1) Skip section navigation (2)

Re: [COMMITTERS] pgsql: Remove some of the most blatant brain-fade in the recent guc

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)postgresql(dot)org>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Remove some of the most blatant brain-fade in the recent guc
Date: 2007-04-27 02:47:20
Message-ID: 200704270247.l3R2lKE04897@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Is anyone working on this fix?

---------------------------------------------------------------------------

Tom Lane wrote:
> Log Message:
> -----------
> Remove some of the most blatant brain-fade in the recent guc patch
> (it's so nice to have a buildfarm member that actively rejects naked
> uses of strcasecmp).  This coding is still pretty awful, though, since
> it's going to be O(N^2) in the number of guc variables.  May I direct
> your attention to bsearch?
> 
> Modified Files:
> --------------
>     pgsql/src/backend/utils/misc:
>         guc.c (r1.387 -> r1.388)
>         (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c.diff?r1=1.387&r2=1.388)
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2007-04-27 02:57:37
Subject: Re: [HACKERS] autovacuum does not start in HEAD
Previous:From: Bruce MomjianDate: 2007-04-27 02:45:49
Subject: Re: pgsql crollable cursor doesn't support one form of postgresql's cu

pgsql-committers by date

Next:From: Tom LaneDate: 2007-04-27 03:19:15
Subject: Re: [COMMITTERS] pgsql: Remove some of the most blatant brain-fade in the recent guc
Previous:From: User H-saitoDate: 2007-04-27 01:49:10
Subject: psqlodbc - psqlodbc: Prep for 08.02.0400 release.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group