Skip site navigation (1) Skip section navigation (2)

Re: Reviewers Guide to Deferred Transactions/TransactionGuarantee

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Reviewers Guide to Deferred Transactions/TransactionGuarantee
Date: 2007-04-27 01:00:27
Message-ID: 200704270100.l3R10RH19311@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Your patch has been added to the PostgreSQL unapplied patches list at:

	http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------


Simon Riggs wrote:
> On Thu, 2007-04-05 at 22:56 +0100, Simon Riggs wrote:
> > transaction_guarantee.v11.patch 
> 
> correct files attached
> 
> > Open Questions
> > --------------
> > 
> > 1. Should the DFC use a standard hash table? Custom code allows both
> > additional speed and the ability to signal when it fills.
> > 
> > 2. Should tqual.c update the LSN of a heap page with the LSN of the
> > transaction commit that it can read from the DF cache?
> 
> I now think we should update the LSN of the page, but not changed yet.
> 
> > 3. Should the WALWriter also do the wal_buffers half-full write at the
> > start of XLogInsert() ?
> 
> Not that important
> 
> > 4. The recent changes to remove CheckpointStartLock haven't changed the
> > code path for deferred transactions, so a similar solution might be
> > possible there also.
> 
> Some further discussion required here, I think. That change may actually
> have introduced a slight risk into the patch. Will raise at review.
> 
> > 5. Is it correct to do WAL-before-flush for clog only, or should this
> > be multixact also?
> 
> Not necessary
> 
> -- 
>   Simon Riggs             
>   EnterpriseDB   http://www.enterprisedb.com
> 

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2007-04-27 01:01:40
Subject: Re: Reviewers Guide to Deferred Transactions/TransactionGuarantee
Previous:From: Bruce MomjianDate: 2007-04-27 00:54:51
Subject: Re: [PATCHES] Fix for large file support

pgsql-patches by date

Next:From: Bruce MomjianDate: 2007-04-27 01:01:40
Subject: Re: Reviewers Guide to Deferred Transactions/TransactionGuarantee
Previous:From: Bruce MomjianDate: 2007-04-27 00:54:51
Subject: Re: [PATCHES] Fix for large file support

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group