Re: autovacuum multiworkers, patch 5

ITAGAKI Takahiro wrote:
>
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> wrote:
>
> > > > I manually merged your patch on top of my own. This is the result.
> > > > Please have a look at whether the new code is correct and behaves sanely
> > > > (I haven't tested it).
> >
> > Huh, you are right, it is broken, even in my outgoing mailbox -- I don't
> > know what happened, as the file I have on disk is complete. Here is
> > attached again.
>
> I tested your patch on Linux and Windows. It works well on Linux,
> where we use fork(), but falls into segfault on Windows, where we
> use exec(). Maybe you forgot to initialize the shared memory stuff.
> (I haven't find out where to be fixed, sorry.)

Ok, thanks, this confirms that I have to try the EXEC_BACKEND code path.

> Multiworker and balancing seem to work well after they successfully start up.

Great.

--
Alvaro Herrera http://www.CommandPrompt.com/
PostgreSQL Replication, Consulting, Custom Development, 24x7 support