Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] [Fwd: Index Advisor]

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org, PGSQL-Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] [Fwd: Index Advisor]
Date: 2007-04-11 20:52:16
Message-ID: 200704112052.l3BKqGI17906@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Gurjeet Singh wrote:
>     The interface etc. may not be beautiful, but it isn't ugly either! It is
> a lot better than manually creating pg_index records and inserting them into
> cache; we use index_create() API to create the index (build is deferred),
> and then 'rollback to savepoint' to undo those changes when the advisor is
> done. index_create() causes pg_depends entries too, so a 'RB to SP' is far
> much safer than going and deleting cache records manually.

My complaint was not that the API used in the code was non-optimal(which
I think was Tom's issue), but that the _user_ API was not very clean. 
Not sure what to recommend, but I will think about it later.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2007-04-11 20:55:53
Subject: Re: Vista/IPv6
Previous:From: Merlin MoncureDate: 2007-04-11 20:52:02
Subject: Fwd: patch to suppress psql timing output in quiet mode

pgsql-patches by date

Next:From: Bruce MomjianDate: 2007-04-11 21:02:44
Subject: Re: Packed Varlena Update (v21)
Previous:From: Merlin MoncureDate: 2007-04-11 20:52:02
Subject: Fwd: patch to suppress psql timing output in quiet mode

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group