Skip site navigation (1) Skip section navigation (2)

Re: Re: [HACKERS] [COMMITTERS] pgsql: Add GUC temp_tablespaces to provide a default location for

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jaime Casanova <systemguards(at)gmail(dot)com>, Albert Cervera Areny <albertca(at)hotpop(dot)com>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Re: [HACKERS] [COMMITTERS] pgsql: Add GUC temp_tablespaces to provide a default location for
Date: 2007-04-02 22:57:44
Message-ID: 200704022257.l32Mvik15073@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackerspgsql-patches
This has been saved for the 8.4 release:

	http://momjian.postgresql.org/cgi-bin/pgpatches_hold

---------------------------------------------------------------------------

Bruce Momjian wrote:
> 
> OK, patch reverted.  Authors, would you please resubmit with fixes? 
> Thanks.
> 
> ---------------------------------------------------------------------------
> 
> Tom Lane wrote:
> > momjian(at)postgresql(dot)org (Bruce Momjian) writes:
> > > Add GUC temp_tablespaces to provide a default location for temporary
> > > objects.
> > > Jaime Casanova
> > 
> > I hadn't looked at this patch before, but now that I have, it is
> > rather broken.
> > 
> > In the first place, it makes no provision for RemovePgTempFiles() to
> > clean up leftover temp files that are in non-default places.
> > 
> > In the second place, it's a serious violation of what little modularity
> > and layering we have for fd.c to be calling into commands/tablespace.c.
> > This is not merely cosmetic but has real consequences: one being that
> > it's now unsafe to call OpenTemporaryFile outside a transaction.
> > 
> > Please revert until the submitter can come up with a better-designed
> > patch.
> > 
> > 			regards, tom lane
> > 
> > ---------------------------(end of broadcast)---------------------------
> > TIP 4: Have you searched our list archives?
> > 
> >                http://archives.postgresql.org
> 
> -- 
>   Bruce Momjian  <bruce(at)momjian(dot)us>          http://momjian.us
>   EnterpriseDB                               http://www.enterprisedb.com
> 
>   + If your life is a hard drive, Christ can be your backup. +


> 
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2007-04-02 23:00:36
Subject: Re: PL/Python warnings in CVS HEAD
Previous:From: Bruce MomjianDate: 2007-04-02 22:54:43
Subject: Re: UTF8MatchText

pgsql-committers by date

Next:From: Bruce MomjianDate: 2007-04-02 23:25:20
Subject: pgsql: Add URL for: o Allow commenting of variables in
Previous:From: Bruce MomjianDate: 2007-04-02 22:50:19
Subject: pgsql: Add URL for: o Allow a warm standby system to also

pgsql-patches by date

Next:From: Bruce MomjianDate: 2007-04-02 23:06:11
Subject: Re: CREATE TABLE LIKE INCLUDING INDEXES support
Previous:From: Bruce MomjianDate: 2007-04-02 22:54:43
Subject: Re: UTF8MatchText

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group