Skip site navigation (1) Skip section navigation (2)

Re: UTF8MatchText

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: Andrew - Supernews <andrew(at)supernews(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: UTF8MatchText
Date: 2007-04-02 22:54:43
Message-ID: 200704022254.l32Msh914608@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
I assume this replaces all your earlier multi-byte LIKE patches.

Your patch has been added to the PostgreSQL unapplied patches list at:

	http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------


ITAGAKI Takahiro wrote:
> "Andrew - Supernews" <andrew(at)supernews(dot)net> wrote:
> 
> >  ITAGAKI> I think all "safe ASCII-supersets" encodings are comparable
> >  ITAGAKI> by bytes, not only UTF-8.
> > 
> > This is false, particularly for EUC.
> 
> Umm, I see. I updated the optimization to be used only for UTF8 case.
> I also added some inlining hints that are useful on my machine (Pentium 4).
> 
> 
> x1000 of LIKE '%foo% on 10000 rows tables [ms]
>  encoding  | HEAD  |  P1   |  P2   |  P3  
> -----------+-------+-------+-------+-------
>  SQL_ASCII |  7094 |  7120 |  7063 |  7031
>  LATIN1    |  7083 |  7130 |  7057 |  7031
>  UTF8      | 17974 | 10859 | 10839 |  9682
>  EUC_JP    | 17032 | 17557 | 17599 | 15240
> 
> - P1: UTF8MatchText()
> - P2: P1 + __inline__ GenericMatchText()
> - P3: P2 + __inline__ wchareq()
>       (The attached patch is P3.)
> 
> Regards,
> ---
> ITAGAKI Takahiro
> NTT Open Source Software Center
> 

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 7: You can help support the PostgreSQL project by donating at
> 
>                 http://www.postgresql.org/about/donate

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2007-04-02 22:57:44
Subject: Re: Re: [HACKERS] [COMMITTERS] pgsql: Add GUC temp_tablespaces to provide a default location for
Previous:From: Chris BrowneDate: 2007-04-02 22:52:50
Subject: Re: Modifying TOAST thresholds

pgsql-patches by date

Next:From: Bruce MomjianDate: 2007-04-02 22:57:44
Subject: Re: Re: [HACKERS] [COMMITTERS] pgsql: Add GUC temp_tablespaces to provide a default location for
Previous:From: Bruce MomjianDate: 2007-04-02 22:47:06
Subject: Re: Updateable cursors patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group