Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Guido Goldstein <guido(dot)goldstein(at)a-nugget(dot)org>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,
Date: 2007-04-02 21:11:09
Message-ID: 200704022111.l32LB9p15002@momjian.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackerspgsql-patches
Added to TODO:

        o Allow PL/Python to return boolean rather than 1/0

          http://archives.postgresql.org/pgsql-patches/2007-01/msg00596$

---------------------------------------------------------------------------

Guido Goldstein wrote:
> Peter Eisentraut wrote:
> > Guido Goldstein wrote:
> >> Is it possible to tell me which python versions you want to
> >> support?
> > 
> > The issue isn't so much which versions we want to support.  There is 
> > certainly some flexibility with that.  But when a patch breaks the 
> > buildfarm a) unannounced and b) without any apparent feature gain, then 
> > people get annoyed.
> 
> If this breaks the buildfarm it's not my failure.
> Except you can tell me what I've got to do with the
> buildfarm.
> 
> If you mean that plpython didn't compile, fine; simply tell
> the people what version they should consider when sending
> in patches.
> 
> I've checked the patch with postgres 8.1.3 and 8.2.1
> with python 2.4 and 2.5 on intel 32 bit and amd 64 bit
> systems; all systems running linux.
> 
> *And* it's not a feature patch but a bug-fixing one!
> Python is a language with strong typing, so silently
> converting a datatype is a bug -- not a feature.
> Btw, you'll lose the type information of boolean columns in
> trigger functions (NEW and OLD dicts, no explicit parameters),
> which does cause problems.
> 
> > That said, we certainly try to support a few more versions of Python 
> [...]
> 
> If you want to support python 2.3 use the attached patch, which also
> works for the newer python versions.
> The Python 2.3 branch is the oldest _officially_ supported python version.
> 
> Anyway, to circumvent the above mentiond point a) I herewith anncounce
> that the included patch might break the buildfarm.
> 
> Cheers
>    Guido
> 


> 
> ---------------------------(end of broadcast)---------------------------
> TIP 5: don't forget to increase your free space map settings

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2007-04-02 21:16:28
Subject: Re: [HACKERS] Full page writes improvement, code update
Previous:From: Zdenek KotalaDate: 2007-04-02 21:09:03
Subject: Re: Questions about pid file creation code

pgsql-committers by date

Next:From: Bruce MomjianDate: 2007-04-02 21:25:34
Subject: pgsql: Add: > * Fix to_date()-related functions to consistently issue
Previous:From: Bruce MomjianDate: 2007-04-02 21:10:53
Subject: pgsql: Add: > > o Allow PL/Python to return boolean rather than 1/0

pgsql-patches by date

Next:From: Bruce MomjianDate: 2007-04-02 21:16:28
Subject: Re: [HACKERS] Full page writes improvement, code update
Previous:From: Bruce MomjianDate: 2007-04-02 21:00:50
Subject: Re: [PATCHES] Use non-deprecated APIs for dynloader/darwin.c

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group