Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Arrays of Complex Types

From: David Fetter <david(at)fetter(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Cc: PG Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Arrays of Complex Types
Date: 2007-04-02 20:10:05
Message-ID: 20070402201005.GD29411@fetter.org (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On Fri, Mar 30, 2007 at 05:08:42PM -0400, Tom Lane wrote:
> David Fetter <david(at)fetter(dot)org> writes:
> > After several rounds of patches, it appears that it might be easier to
> > create a new typtype entry, which I'll tentatively call 'a' because it
> > seems a little fragile and a lot inelegant and hard to maintain to
> > have typtype='c' and typrelid=InvalidOid mean, "this is an array of
> > complex types."
> 
> Uh, wouldn't it be typtype = 'c' and typelem != 0 ?

Right.  The attached patch passes the current regression tests and at
least to a "smoke test" level does what it's supposed to do.  I'd
really like to help refactor the whole array system to use 'a', tho.

Cheers,
D
-- 
David Fetter <david(at)fetter(dot)org> http://fetter.org/
phone: +1 415 235 3778        AIM: dfetter666
                              Skype: davidfetter

Remember to vote!
Consider donating to PostgreSQL: http://www.postgresql.org/about/donate

In response to

Responses

pgsql-hackers by date

Next:From: Tom LaneDate: 2007-04-02 20:11:35
Subject: Re: Questions about pid file creation code
Previous:From: Bruce MomjianDate: 2007-04-02 19:57:40
Subject: Re: So are we calling it: Feature Freeze?

pgsql-patches by date

Next:From: Bruce MomjianDate: 2007-04-02 20:13:23
Subject: Re: Concurrent psql v4 [WIP]
Previous:From: Bruce MomjianDate: 2007-04-02 20:01:44
Subject: Re: [Fwd: Deferred Transactions, Transaction Guarantee and COMMITwithout waiting]

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group