Skip site navigation (1) Skip section navigation (2)

Re: Macros for typtype (was Re: Arrays of Complex Types)

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Fetter <david(at)fetter(dot)org>
Subject: Re: Macros for typtype (was Re: Arrays of Complex Types)
Date: 2007-04-01 00:28:54
Message-ID: 200704010228.56249.peter_e@gmx.net (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bruce Momjian wrote:
> > I just realized that I need to check every usage of typtype to be
> > sure that the enums patch is sane.  So, barring objection, I intend
> > to take this opportunity to make the code stop referring directly
> > to 'b', 'c' etc whereever possible.  Any objections to these names?
> >
> > #define	TYPTYPE_BASE		'b'
> > #define	TYPTYPE_COMPOSITE	'c'
> > #define	TYPTYPE_DOMAIN		'd'
> > #define	TYPTYPE_ENUM		'e'
> > #define	TYPTYPE_PSEUDO		'p'
>
> I like macros.  ;-)

Why not enums? ;-)

-- 
Peter Eisentraut
http://developer.postgresql.org/~petere/

In response to

Responses

pgsql-hackers by date

Next:From: Greg SmithDate: 2007-04-01 01:30:34
Subject: pgbench transaction timestamps
Previous:From: David FetterDate: 2007-04-01 00:22:18
Subject: Re: Macros for typtype (was Re: Arrays of Complex Types)

pgsql-patches by date

Next:From: Tom DunstanDate: 2007-04-01 01:05:48
Subject: Re: Current enums patch
Previous:From: David FetterDate: 2007-04-01 00:22:18
Subject: Re: Macros for typtype (was Re: Arrays of Complex Types)

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group