Re: RESET SESSION

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Marko Kreen <markokr(at)gmail(dot)com>, PGSQL-Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: RESET SESSION
Date: 2007-03-30 18:32:54
Message-ID: 200703301832.l2UIWtf06402@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> "Marko Kreen" <markokr(at)gmail(dot)com> writes:
> > RESET TEMPS -- please suggest better name
>
> RESET TEMP (should allow RESET TEMPORARY too). I see no reason to add
> a new keyword when the existing one will do fine.
>
> > So in the end RESET SESSION basically executes following commands:
>
> > ABORT;
>
> I object to having RESET SESSION include an ABORT. That will make it
> a transaction control statement and complicate matters for a whole
> lot of things. If you don't know whether you're in a transaction or
> not, you can send ABORT for yourself, but in practice I think most
> client code already tracks that (or easily can).

It seems strange RESET SESSION would not terminate open transactions,
but on the other hand calling RESET SESSION in a transaction seems odd
too.

I think we should at least throw an error if someone tries RESET SESSION
inside a transaction, and hopefully administrators will realize they
have a problem. Perhaps we can even offer a hint how to close open
transactions.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2007-03-30 19:02:35 Re: RESET SESSION
Previous Message Bruce Momjian 2007-03-30 17:45:21 Re: Fwd: Re: [pgsql-patches] pg_get_domaindef