Re: ECPG threads test

Magnus Hagander wrote:
> Bruce Momjian wrote:
> > Magnus Hagander wrote:
> >> Hi!
> >>
> >> >From what I can see, the ecpg thread tests (src/interfaces/ecpg/threads)
> >
> > Uh, the directory src/interfaces/ecpg/threads doesn't exist. I assume
> > you mean src/interfaces/ecpg/test/thread.
>
> Yes, that's what I mean. Sorry 'bout that.
>
>
> >> don't ever run. They rely on ENABLE_THREAD_SAFETY to be set, but even when
> >> I build with --enable-thread-safety, it's not set. This is because ecpg
> >> does not pull in pg_config.h, and also does not specify it on the
> >> commandline.
> >
> > Yep, that's a problem. Michael Meskes committed thoses files on
> > 2006/08/02 so I am hoping he can address it.
>
> Ok. At least I'm not completely lost then.
>
> I'll see if I can put something together while I do the rest of that
> work, but if Michael (or someone else) has a quick-fix, go ahead.

I believe the solution is to test in the Makefile, and just not call the
thread part at all unless threading is enabled. Doing the thread test
in the C code is not going to work because it will not produce output
that matches the expected file.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +