Skip site navigation (1) Skip section navigation (2)

Re: Small code clean-up

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Small code clean-up
Date: 2007-03-28 08:06:15
Message-ID: 20070328080615.GA11810@svr2.hagander.net (view raw or flat)
Thread:
Lists: pgsql-patches
On Wed, Mar 28, 2007 at 10:23:09AM +0900, ITAGAKI Takahiro wrote:
> Here are two small code clean-up in initdb and win32_shmem.
> 
> pg_char_to_encoding() was redundant in initdb because
> pg_valid_server_encoding() returns the same result if the encoding is valid,
> 
> Changes in win32_shmem suppress the following warnings.
> | pg_shmem.c: In function `PGSharedMemoryCreate':
> | pg_shmem.c:137: warning: long unsigned int format, Size arg (arg 2)
> | pg_shmem.c:159: warning: long unsigned int format, Size arg (arg 2)
> 

When you send two completely unrelated patches, please send them in
separate emails.

I have applied the win32 shmem part, thanks. Haven't had time to look into
the other one.

//Magnus


In response to

pgsql-patches by date

Next:From: Magnus HaganderDate: 2007-03-28 08:36:54
Subject: Re: O_DIRECT support for Windows
Previous:From: Andrew - SupernewsDate: 2007-03-28 07:05:24
Subject: Re: Arrays of Complex Types

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group