Re: DEALLOCATE ALL

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Marko Kreen <markokr(at)gmail(dot)com>
Cc: PGSQL-Patches <pgsql-patches(at)postgresql(dot)org>, Andrzej Rusin <Andrzej(dot)Rusin(at)interia(dot)pl>
Subject: Re: DEALLOCATE ALL
Date: 2007-03-27 17:32:00
Message-ID: 20070327173200.GB3966@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Marko Kreen wrote:
> When pooling connections where prepared statements are in use,
> it is hard to give new client totally clean connection as
> there may be allocated statements that give errors when
> new client starts preparing statements again.

Huh, didn't we have a RESET SESSION command to do just that? What about
cursors, for example?

> I did it slightly hacky way - if DeallocateStmt->name is
> NULL is signifies DEALLOCATE ALL command. All the code
> that looks into DeallocateStmt seems to survive the situation
> so it should be problem. If still a new node is needed
> or additional field in the node I can rework the patch.

Wouldn't it be easier to just add a bool to DeallocateStmt?

--
Alvaro Herrera http://www.PlanetPostgreSQL.org
"Si un desconocido se acerca y te regala un CD de Ubuntu ...
Eso es ... Eau de Tux"

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2007-03-27 17:34:20 Re: Recalculating OldestXmin in a long-running vacuum
Previous Message Bruce Momjian 2007-03-27 17:27:42 Re: [pgsql-patches] pg_get_domaindef