Skip site navigation (1) Skip section navigation (2)

Re: Fast CLUSTER

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: pgsql-patches(at)postgresql(dot)org, Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Subject: Re: Fast CLUSTER
Date: 2007-03-27 14:28:54
Message-ID: 200703271428.l2RESs016552@momjian.us (view raw or flat)
Thread:
Lists: pgsql-patches
Simon Riggs wrote:
> On Thu, 2007-02-22 at 22:49 +0000, Simon Riggs wrote:
> > On Tue, 2007-02-20 at 14:38 -0300, Alvaro Herrera wrote:
> > 
> > > Cool.  I noticed that the SGML seems broken here:
> > 
> > Corrected. 
> > 
> > > You need to close the <listitem> and <para> opened in the COPY mention.
> > > 
> > > > + 
> > > > + static void
> > > > + heap_sync_relation(Relation rel)
> > > > + {
> > > > + 	if (!rel->rd_istemp)
> > > 
> > > No comment in this function?
> > 
> > I've added more comments as you suggest.
> > 
> > Thanks for the review.
> 
> Could we add this to the unapplied patches queue? It seems to have been
> missed off the list. Thanks.

Done.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-patches by date

Next:From: Marko KreenDate: 2007-03-27 14:29:53
Subject: DEALLOCATE ALL
Previous:From: Bruce MomjianDate: 2007-03-27 14:28:35
Subject: Re: Fast CLUSTER

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group