From:
Bruce Momjian <bruce(at)momjian(dot)us>
To:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc:
Simon Riggs <simon(at)2ndquadrant(dot)com>,
Chris Campbell <chris(at)bignerdranch(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject:
Re: [HACKERS] Deadlock with pg_dump?
Date:
2007-03-02 20:20:27
Message-ID:
200703022020.l22KKRQ00125@momjian.us (view raw or flat )
Thread:
2006-10-26 20:45:02 from Chris Campbell <chris(at)bignerdranch(dot)com>
2006-10-26 21:21:26 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2006-10-26 22:11:59 from Chris Campbell <chris(at)bignerdranch(dot)com>
2006-10-26 22:29:11 from "Jim C(dot) Nasby" <jim(at)nasby(dot)net>
2006-10-26 22:45:08 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2006-10-26 23:23:12 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2006-10-27 00:27:31 from Chris Campbell <chris(at)bignerdranch(dot)com>
2006-10-30 20:49:57 from "Simon Riggs" <simon(at)2ndquadrant(dot)com>
2007-02-14 03:19:15 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-02-19 19:38:41 from "Simon Riggs" <simon(at)2ndquadrant(dot)com>
2007-02-19 22:29:40 from "Simon Riggs" <simon(at)2ndquadrant(dot)com>
2007-02-26 18:34:01 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-02-26 19:01:24 from "Simon Riggs" <simon(at)2ndquadrant(dot)com>
2007-02-26 19:11:23 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-02-26 19:19:49 from "Simon Riggs" <simon(at)2ndquadrant(dot)com>
2007-02-26 19:28:26 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-02-26 19:31:49 from "Simon Riggs" <simon(at)2ndquadrant(dot)com>
2007-02-26 19:52:03 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-02-26 20:05:07 from "Simon Riggs" <simon(at)2ndquadrant(dot)com>
2007-02-26 20:10:49 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-02-26 20:15:43 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-03-01 02:06:15 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-03-01 05:45:54 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-03-01 14:06:41 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-03-01 19:17:20 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-03-02 18:35:41 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-03-02 18:51:32 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-03-02 20:20:27 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-03-02 20:55:05 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-03-02 22:05:41 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-03-02 22:37:33 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-03-02 22:46:40 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-03-02 23:38:54 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-03-03 02:40:54 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-03-03 02:43:54 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-03-03 18:49:32 from Bruce Momjian <bruce(at)momjian(dot)us>
2006-11-21 04:40:15 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Lists:
pgsql-hackers pgsql-patches
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Are people going to be happy that log_statement and
> > log_min_duration_statement output the statement twice?
>
> If those are the only cases you're worried about, a far simpler solution
> is to clear debug_query_string before instead of after emitting those
> log messages.
I am concerned about setting debug_query_string to NULL, calling
ereport(), and then resetting it might cause problems because of cases
where ereport might want to access debug_query_string for other uses,
for cases where ereport doesn't return to the reset code (but I assume
that is handled), and for cases like pgmonitor that would stop a
backend, read debug_query_string, and disconnect.
I can create a global variable to control this, but the new elog level
seemed cleaner.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://www.enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
In response to
Responses
pgsql-hackers by date
Next :From: Bruce MomjianDate: 2007-03-02 20:20:58
Subject : Re: Final version of IDENTITY/GENERATED patch
Previous :From : Oleg BartunovDate : 2007-03-02 20:08:08
Subject : Re: Google SoC: lots of discussion, very few mentors
pgsql-patches by date
Next :From: Bruce MomjianDate: 2007-03-02 20:20:58
Subject : Re: Final version of IDENTITY/GENERATED patch
Previous :From : Zoltan BoszormenyiDate : 2007-03-02 19:55:25
Subject : Re: Final version of IDENTITY/GENERATED patch