Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Deadlock with pg_dump?

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, Chris Campbell <chris(at)bignerdranch(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Deadlock with pg_dump?
Date: 2007-03-01 02:06:15
Message-ID: 200703010206.l2126FY01384@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > This is not the first GUC that has needed this.
> 
> Exactly.  I think that we simply made a mistake in the initial
> implementation of log_min_error_statement: we failed to think about
> whether it should use client or server priority ordering, and the
> easy-to-code behavior was the wrong one.

I have coded up the following patch which places LOG just above ERROR in
log_min_error_statement.

It also adds the new log level LOG_NO_STATEMENT, which is used only for
internal use by ereport() calls that should not print the statement. 
This is particularly useful so log_statemant and
log_min_duration_statement do not print the statement twice.

-- 
  Bruce Momjian  <bruce(at)momjian(dot)us>          http://momjian.us
  EnterpriseDB                               http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

Attachment: /pgpatches/log_min
Description: text/x-diff (11.6 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2007-03-01 02:09:55
Subject: Re: What is CheckPoint.undo needed for?
Previous:From: ITAGAKI TakahiroDate: 2007-03-01 02:00:36
Subject: Re: VACUUM and spoiling the buffer manager cache

pgsql-patches by date

Next:From: Bruce MomjianDate: 2007-03-01 02:08:43
Subject: Re: Split _bt_insertonpg to two functions
Previous:From: Patric BechtelDate: 2007-03-01 01:37:28
Subject: Re: Numeric patch to add special-case representations for < 8 bytes

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group