Skip site navigation (1) Skip section navigation (2)

Re: recovery.conf parsing problems

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Simon Riggs <simon(at)2ndquadrant(dot)com>
Cc: andrew(at)supernews(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: recovery.conf parsing problems
Date: 2007-02-03 22:32:32
Message-ID: 200702032232.l13MWW827203@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Added to TODO:

          o Allow recovery.conf to allow the same syntax as
	    postgresql.conf, including quoting


            http://archives.postgresql.org/pgsql-hackers/2006-12/msg00497.php


---------------------------------------------------------------------------

Simon Riggs wrote:
> On Wed, 2006-12-13 at 19:28 +0000, Simon Riggs wrote:
> > On Wed, 2006-12-13 at 04:23 +0000, Andrew - Supernews wrote:
> > > While testing a PITR recovery, I discovered that recovery.conf doesn't
> > > seem to allow specifying ' in the command string, making it hard to
> > > protect the restore_command against problematic filenames (whitespace
> > > etc.). This doesn't seem to be a problem for archive_command, which
> > > allows \' (e.g. archive_command = '/path/to/script \'%f\' \'%p\'').
> 
> Immediate workaround is to use a script to encapsulate the actual
> desired request.
> 
> > > Should this be fixed?
> > 
> > Yes, I'll look into that.
> 
> OK, I would propose to extend the guc-file.l to include sufficient code
> to allow the parsing of the conf files to be identical between the
> postgresql.conf and the recovery.conf (it isn't the same yet).
> 
> There'll be care taken to ensure that the various options are not
> settable in the wrong file.
> 
> Any requests for specific implementation details? I'll be looking to
> remove code from xlog.c, if possible.
> 
> Implementation won't be immediate because of other current work.
> 
> -- 
>   Simon Riggs             
>   EnterpriseDB   http://www.enterprisedb.com
> 
> 
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend

-- 
  Bruce Momjian   bruce(at)momjian(dot)us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2007-02-03 23:36:28
Subject: Re: 8.1.5 release note
Previous:From: Joshua D. DrakeDate: 2007-02-03 22:25:17
Subject: Re: Proposal: Change of pg_trigger.tg_enabled and adding

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group