Skip site navigation (1) Skip section navigation (2)

Re: pg_restore fails with a custom backup file

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Zeugswetter Andreas ADI SD <ZeugswetterA(at)spardat(dot)at>,Andrew Dunstan <andrew(at)dunslane(dot)net>,Yoshiyuki Asaba <y-asaba(at)sraoss(dot)co(dot)jp>, z-saito(at)guitar(dot)ocn(dot)ne(dot)jp,pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_restore fails with a custom backup file
Date: 2007-02-01 11:27:05
Message-ID: 20070201112705.GA16939@svr2.hagander.net (view raw or flat)
Thread:
Lists: pgsql-hackers
Still sitting on my TODO. I have a working solution for MSVC, but it
didn't run on MingW. Andreas had a working solution on his MingW, but it
didn't work on my MingW.
I need to merge them together for something that works on all three. I
hope to have this done for 8.3, and possibly a 8.2.x, but will most
likely no thave time to do it before the next 8.2.x to come out. But
perhaps the one after that.

//Magnus


On Wed, Jan 31, 2007 at 11:41:09PM -0500, Bruce Momjian wrote:
> 
> Where are we on this?
> 
> ---------------------------------------------------------------------------
> 
> Magnus Hagander wrote:
> > On Tue, Dec 19, 2006 at 04:58:22PM +0100, Zeugswetter Andreas ADI SD wrote:
> > > 
> > > > > > > MinGW has fseeko64 and ftello64 with off64_t.
> > > > > > >   
> > > > > > 
> > > > > > Maybe we need separate macros for MSVC and MinGW. Given the other 
> > > > > 
> > > > > You mean something quick and dirty like this ? That would work.
> > > > 
> > > > Yes, except does that actually work? If so you found the place in the
> > > > headers to stick it without breaking things that I couldn't find ;-)
> > > 
> > > Compiles clean without warnings on MinGW, but not tested, sorry also no
> > > time.
> > 
> > Does not compile on my MinGW - errors in the system headers (unistd.h,
> > io.h) due to changing the argument format for chsize(). The change of
> > off_t propagated into parts of the system headers, thus chaos was
> > ensured.
> > 
> > I still think we need to use a pgoff_t. Will look at combining these two
> > approaches.
> > 
> > //Magnus
> > 
> > ---------------------------(end of broadcast)---------------------------
> > TIP 6: explain analyze is your friend
> 
> -- 
>   Bruce Momjian   bruce(at)momjian(dot)us
>   EnterpriseDB    http://www.enterprisedb.com
> 
>   + If your life is a hard drive, Christ can be your backup. +

In response to

pgsql-hackers by date

Next:From: Simon RiggsDate: 2007-02-01 11:33:40
Subject: Re: max_locks_per_transactions ...
Previous:From: Simon RiggsDate: 2007-02-01 11:25:40
Subject: Re: Data archiving/warehousing idea

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group