Skip site navigation (1) Skip section navigation (2)

Re: pg_restore fails with a custom backup file

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: Zeugswetter Andreas ADI SD <ZeugswetterA(at)spardat(dot)at>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Yoshiyuki Asaba <y-asaba(at)sraoss(dot)co(dot)jp>, z-saito(at)guitar(dot)ocn(dot)ne(dot)jp, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pg_restore fails with a custom backup file
Date: 2007-02-01 04:41:09
Message-ID: 200702010441.l114f9416245@momjian.us (view raw or flat)
Thread:
Lists: pgsql-hackers
Where are we on this?

---------------------------------------------------------------------------

Magnus Hagander wrote:
> On Tue, Dec 19, 2006 at 04:58:22PM +0100, Zeugswetter Andreas ADI SD wrote:
> > 
> > > > > > MinGW has fseeko64 and ftello64 with off64_t.
> > > > > >   
> > > > > 
> > > > > Maybe we need separate macros for MSVC and MinGW. Given the other 
> > > > 
> > > > You mean something quick and dirty like this ? That would work.
> > > 
> > > Yes, except does that actually work? If so you found the place in the
> > > headers to stick it without breaking things that I couldn't find ;-)
> > 
> > Compiles clean without warnings on MinGW, but not tested, sorry also no
> > time.
> 
> Does not compile on my MinGW - errors in the system headers (unistd.h,
> io.h) due to changing the argument format for chsize(). The change of
> off_t propagated into parts of the system headers, thus chaos was
> ensured.
> 
> I still think we need to use a pgoff_t. Will look at combining these two
> approaches.
> 
> //Magnus
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend

-- 
  Bruce Momjian   bruce(at)momjian(dot)us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2007-02-01 04:52:30
Subject: Re: Security leak with trigger functions?
Previous:From: Bruce MomjianDate: 2007-02-01 04:36:15
Subject: Re: FOR SHARE vs FOR UPDATE locks

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group