Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

From: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Hannu Krosing <hannu(at)skype(dot)net>, Guido Goldstein <guido(dot)goldstein(at)a-nugget(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,
Date: 2007-01-31 13:34:25
Message-ID: 20070131133424.GB22158@alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

Bruce Momjian wrote:
> Hannu Krosing wrote:
> > Officially by who ?
> >
> > 2.3 was the first version to introduce bool as a subtype of int, in
> > 2.2.3 True and False were introduced as two variables pointing to
> > integers 1 and 0.
> >
> > So to make your patch ok on all python versions, just make it
> > conditional on python version being 2.3 or bigger, and return int for
> > pre-2.3.
>
> I thought about suggesting that, but do we want plpython to have
> different result behavior based on the version of python used? I didn't
> think so.

The alternative would be, what, including the whole python source in our
distribution? Because the Python guys themselves changed the behavior
depending on the version.

--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tino Wildenhain 2007-01-31 13:59:03 Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,
Previous Message Bruce Momjian 2007-01-31 12:57:37 Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

Browse pgsql-hackers by date

  From Date Subject
Next Message Tino Wildenhain 2007-01-31 13:59:03 Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,
Previous Message Bruce Momjian 2007-01-31 12:57:37 Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,

Browse pgsql-patches by date

  From Date Subject
Next Message Tino Wildenhain 2007-01-31 13:59:03 Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,
Previous Message Bruce Momjian 2007-01-31 12:57:37 Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,