From:
Alvaro Herrera <alvherre(at)commandprompt(dot)com>
To:
Bruce Momjian <bruce(at)momjian(dot)us>
Cc:
Hannu Krosing <hannu(at)skype(dot)net>,
Guido Goldstein <guido(dot)goldstein(at)a-nugget(dot)org>,
Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org,
pgsql-patches(at)postgresql(dot)org
Subject:
Re: [HACKERS] pgsql: Fix for plpython functions; return true/false for boolean,
Date:
2007-01-31 13:34:25
Message-ID:
20070131133424.GB22158@alvh.no-ip.org (view raw or flat )
Thread:
2007-01-25 04:08:51 from momjian(at)postgresql(dot)org (Bruce Momjian)
2007-01-25 06:52:32 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-01-25 15:00:06 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-01-30 10:43:52 from Guido Goldstein <pgpatches(at)a-nugget(dot)org>
2007-01-30 12:39:19 from Peter Eisentraut <peter_e(at)gmx(dot)net>
2007-01-30 13:52:56 from Guido Goldstein <guido(dot)goldstein(at)a-nugget(dot)org>
2007-01-31 09:08:00 from Hannu Krosing <hannu(at)skype(dot)net>
2007-01-31 12:57:37 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-01-31 13:34:25 from Alvaro Herrera <alvherre(at)commandprompt(dot)com>
2007-01-31 13:59:03 from Tino Wildenhain <tino(at)wildenhain(dot)de>
2007-01-31 14:08:38 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-01-31 15:11:13 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-02-20 03:49:27 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-04-02 21:11:09 from Bruce Momjian <bruce(at)momjian(dot)us>
2007-01-30 14:24:22 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2007-01-30 15:17:13 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2007-01-30 16:53:23 from "J(dot) Andrew Rogers" <jrogers(at)neopolitan(dot)com>
Lists:
pgsql-committers pgsql-hackers pgsql-patches
Bruce Momjian wrote:
> Hannu Krosing wrote:
> > Officially by who ?
> >
> > 2.3 was the first version to introduce bool as a subtype of int, in
> > 2.2.3 True and False were introduced as two variables pointing to
> > integers 1 and 0.
> >
> > So to make your patch ok on all python versions, just make it
> > conditional on python version being 2.3 or bigger, and return int for
> > pre-2.3.
>
> I thought about suggesting that, but do we want plpython to have
> different result behavior based on the version of python used? I didn't
> think so.
The alternative would be, what, including the whole python source in our
distribution? Because the Python guys themselves changed the behavior
depending on the version.
--
Alvaro Herrera http://www.CommandPrompt.com/
The PostgreSQL Company - Command Prompt, Inc.
In response to
pgsql-hackers by date
Next :From: Tino WildenhainDate: 2007-01-31 13:59:03Subject : Re: [HACKERS] pgsql: Fix for plpython functions; return true/false
for boolean,Previous :From : Bruce MomjianDate : 2007-01-31 12:57:37Subject : Re: [HACKERS] pgsql: Fix for plpython functions; return
true/false for boolean,
pgsql-committers by date
Next :From: Tino WildenhainDate: 2007-01-31 13:59:03Subject : Re: [HACKERS] pgsql: Fix for plpython functions; return true/false
for boolean,Previous :From : Bruce MomjianDate : 2007-01-31 12:57:37Subject : Re: [HACKERS] pgsql: Fix for plpython functions; return
true/false for boolean,
pgsql-patches by date
Next :From: Tino WildenhainDate: 2007-01-31 13:59:03Subject : Re: [HACKERS] pgsql: Fix for plpython functions; return true/false
for boolean,Previous :From : Bruce MomjianDate : 2007-01-31 12:57:37Subject : Re: [HACKERS] pgsql: Fix for plpython functions; return
true/false for boolean,
