Skip site navigation (1) Skip section navigation (2)

Re: Change draft gmake control

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-docs(at)postgresql(dot)org, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Change draft gmake control
Date: 2007-01-27 20:33:50
Message-ID: 200701272033.l0RKXox24521@momjian.us (view raw or flat)
Thread:
Lists: pgsql-docspgsql-patches
Peter Eisentraut wrote:
> Bruce Momjian wrote:
> > Nothing, but the point is that draft is a modifier and it isn't clear
> >
> > >from that syntax that draft is a modifier and not a target.
> > >
> > > Anyway, certainly you could write this to preserve the target:
> > >
> > > draft:
> > > 	$(MAKE) html DRAFT=Y
> >
> > The problem is that the 'gmake' recursion is done, but then returns
> > and runs the hhml again, so 'gmake draft html' calls "$(MAKE) html
> > DRAFT=Y" and on return from that, the html is called again and
> > rebuilds, so it isn't really draft.
> 
> Well, "gmake draft html" doesn't make any sense anyway, but "gmake 
> draft" by itself does and the new way of writing it is significantly 
> more cumbersome, so I request that this be fixed.

Well, if 'draft' was only for html, I could see suggesting just 'gmake
draft', but 'draft' can be used for Postscript and PDF too.
 
-- 
  Bruce Momjian   bruce(at)momjian(dot)us
  EnterpriseDB    http://www.enterprisedb.com

  + If your life is a hard drive, Christ can be your backup. +

In response to

Responses

pgsql-docs by date

Next:From: Andrew DunstanDate: 2007-01-27 20:47:55
Subject: Re: [pgsql-patches] Change draft gmake control
Previous:From: Tom LaneDate: 2007-01-27 16:38:03
Subject: Re: [pgsql-patches] Change draft gmake control

pgsql-patches by date

Next:From: Andrew DunstanDate: 2007-01-27 20:47:55
Subject: Re: [pgsql-patches] Change draft gmake control
Previous:From: Pavan DeolaseeDate: 2007-01-27 20:21:04
Subject: Re: Ctid chain following enhancement

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group